This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Fix fnType for tern / acorn updates (compatibility for >0.13.0)#43
Open
bfricka wants to merge 3 commits intogoogle:masterfrom
bfricka:tcl-fix
Open
Fix fnType for tern / acorn updates (compatibility for >0.13.0)#43bfricka wants to merge 3 commits intogoogle:masterfrom bfricka:tcl-fix
bfricka wants to merge 3 commits intogoogle:masterfrom
bfricka:tcl-fix
Conversation
Contributor
There was a problem hiding this comment.
Tern is 0.16.0 version today.
Author
There was a problem hiding this comment.
I'm aware, and that is what I tested against, but this is compatible with >=0.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches tern-closure to be compatible w/ some changes in newer versions of tern's acorn parser which was causing it to fail when used with >0.13.0.