Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

C# routing header support#1629

Merged
chrisdunelm merged 2 commits intogoogleapis:masterfrom
chrisdunelm:routing
Oct 27, 2017
Merged

C# routing header support#1629
chrisdunelm merged 2 commits intogoogleapis:masterfrom
chrisdunelm:routing

Conversation

@chrisdunelm
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 17, 2017

Codecov Report

Merging #1629 into master will increase coverage by 0.52%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1629      +/-   ##
============================================
+ Coverage     85.51%   86.04%   +0.52%     
+ Complexity     4268     4214      -54     
============================================
  Files           405      403       -2     
  Lines         16787    16635     -152     
  Branches       1757     1735      -22     
============================================
- Hits          14355    14313      -42     
+ Misses         1849     1742     -107     
+ Partials        583      580       -3
Impacted Files Coverage Δ Complexity Δ
.../google/api/codegen/viewmodel/ApiCallableView.java 71.42% <0%> (-11.91%) 6 <2> (+2)
...pi/codegen/transformer/ApiCallableTransformer.java 95.49% <100%> (ø) 35 <0> (ø) ⬇️
...i/codegen/transformer/SchemaTypeNameConverter.java 36.36% <0%> (-16.97%) 1% <0%> (-2%)
...pi/codegen/transformer/ModelTypeNameConverter.java 75% <0%> (-5%) 6% <0%> (-2%)
...i/codegen/transformer/DiscoGapicMethodContext.java 86.95% <0%> (-4.35%) 9% <0%> (-2%)
.../transformer/java/JavaSchemaTypeNameConverter.java 48.03% <0%> (-3.39%) 21% <0%> (-3%)
...google/api/codegen/transformer/ModelTypeTable.java 85.1% <0%> (-3.03%) 30% <0%> (-9%)
.../com/google/api/codegen/metacode/InitCodeNode.java 79.89% <0%> (-2.67%) 73% <0%> (+2%)
...google/api/codegen/config/PageStreamingConfig.java 37.25% <0%> (-1.8%) 10% <0%> (ø)
...oogle/api/codegen/transformer/SchemaTypeTable.java 64.44% <0%> (-1.69%) 18% <0%> (-5%)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7541056...1945f63. Read the comment docs.

@chrisdunelm chrisdunelm requested a review from jskeet October 17, 2017 19:41
@chrisdunelm
Copy link
Copy Markdown
Contributor Author

I've built pubsub with this change, and confirmed it builds.

@chrisdunelm
Copy link
Copy Markdown
Contributor Author

This requires an as-yet-unreleased version of gax; so will require syncing with gax and dependencies.yaml.

Copy link
Copy Markdown
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mostly looked at the generated code changes, which look nice and simple.

GrpcClient.MergeShelvesAsync, GrpcClient.MergeShelves, effectiveSettings.MergeShelvesSettings);
_callCreateBook = clientHelper.BuildApiCall<CreateBookRequest, Book>(
GrpcClient.CreateBookAsync, GrpcClient.CreateBook, effectiveSettings.CreateBookSettings);
GrpcClient.CreateBookAsync, GrpcClient.CreateBook, effectiveSettings.CreateBookSettings)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@chrisdunelm chrisdunelm merged commit 44b3155 into googleapis:master Oct 27, 2017
garrettjonesgoogle pushed a commit to garrettjonesgoogle/toolkit that referenced this pull request Oct 31, 2017
evaogbe pushed a commit to evaogbe/toolkit that referenced this pull request Nov 11, 2017
@chrisdunelm chrisdunelm deleted the routing branch December 11, 2017 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants