C# routing header support#1629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
============================================
+ Coverage 85.51% 86.04% +0.52%
+ Complexity 4268 4214 -54
============================================
Files 405 403 -2
Lines 16787 16635 -152
Branches 1757 1735 -22
============================================
- Hits 14355 14313 -42
+ Misses 1849 1742 -107
+ Partials 583 580 -3
Continue to review full report at Codecov.
|
|
I've built pubsub with this change, and confirmed it builds. |
|
This requires an as-yet-unreleased version of gax; so will require syncing with gax and dependencies.yaml. |
jskeet
left a comment
There was a problem hiding this comment.
I've mostly looked at the generated code changes, which look nice and simple.
| GrpcClient.MergeShelvesAsync, GrpcClient.MergeShelves, effectiveSettings.MergeShelvesSettings); | ||
| _callCreateBook = clientHelper.BuildApiCall<CreateBookRequest, Book>( | ||
| GrpcClient.CreateBookAsync, GrpcClient.CreateBook, effectiveSettings.CreateBookSettings); | ||
| GrpcClient.CreateBookAsync, GrpcClient.CreateBook, effectiveSettings.CreateBookSettings) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
No description provided.