This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Various small Ruby GAPIC fixes#1660
Merged
geigerj merged 1 commit intogoogleapis:masterfrom Oct 26, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1660 +/- ##
=========================================
Coverage 85.51% 85.51%
Complexity 4268 4268
=========================================
Files 405 405
Lines 16787 16787
Branches 1757 1757
=========================================
Hits 14355 14355
Misses 1849 1849
Partials 583 583Continue to review full report at Codecov.
|
landrito
approved these changes
Oct 26, 2017
| - "lib/{@metadata.protoPath}/**/*" | ||
| # This should be removed in the future after we are sanitizing client files. | ||
| - "lib/{@metadata.versionPath}/**/*" | ||
| # This should be removed in the future once GAPIC files conform more closely to rubocop checks. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
garrettjonesgoogle
pushed a commit
to garrettjonesgoogle/toolkit
that referenced
this pull request
Oct 27, 2017
geigerj
added a commit
to geigerj/toolkit
that referenced
this pull request
Nov 6, 2017
\googleapis#1660 renamed some tasks to introduce `ci:acceptance`, but in the wrong place. The acceptance task should be runnable in all cases, even when there are no smoke tests.
Merged
geigerj
added a commit
that referenced
this pull request
Nov 6, 2017
* Rename Rakefile tasks \#1660 renamed some tasks to introduce `ci:acceptance`, but in the wrong place. The acceptance task should be runnable in all cases, even when there are no smoke tests. * Invoke smoke tests from acceptance tests Also rename parameterized toolkit tests for sanity. * Another test name change Not all tests involve "library"
evaogbe
pushed a commit
to evaogbe/toolkit
that referenced
this pull request
Nov 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public_suffixbreaks the google-cloud-ruby buildci:smoke_testRake task toci:acceptanceso that it runs correctly in google-cloud-ruby CI@overloadstag requires a method signatureFixes #1559, #1652