feat: Allow for info window customization on advanced markers#862
feat: Allow for info window customization on advanced markers#862petereair wants to merge 1 commit intogooglemaps:mainfrom
Conversation
kikoso
force-pushed
the
info-window-customization
branch
from
18eee33 to
0c7d1ec
Compare
| * @param pinConfig the PinConfig object that will be used for the advanced marker | ||
| * @param iconView the custom view to be used on the advanced marker | ||
| * @param collisionBehavior the expected collision behavior | ||
| * @param infoWindowContent optional composable lambda expression for customizing the |
There was a problem hiding this comment.
AdvancedMarkerInfoWindow maps its trailing lambda to the infoWindow parameter of AdvancedMarkerImpl (which replaces the entire info window, including the frame/background), the KDoc should be updated to reflect that:
@param content optional composable lambda expression for customizing the entire info window
(this is also how it is documented in MarkerInfoWindow and AdvancedMarkerImpl)
| * @param pinConfig the PinConfig object that will be used for the advanced marker | ||
| * @param iconView the custom view to be used on the advanced marker | ||
| * @param collisionBehavior the expected collision behavior | ||
| * @param infoWindowContent optional composable lambda expression for customizing the |
There was a problem hiding this comment.
Update documentation here too.
|
@petereair , this looks good, I have left a couple of minor comments. Would you be able to add a sample to the Advanced Markers Activity? |
(cherry picked from commit 1bb27ca)
kikoso
force-pushed
the
info-window-customization
branch
from
0c7d1ec to
e5e5ca4
Compare
|
Hi @petereair . Did you have the chance to check this message? |
|
@kikoso thanks for the followup! I'll get those comments addressed! |
3 participants
This follows the approach used by regular markers which has separate functions for customizing just the content and customizing the whole window. Currently there is no way to customize either.
This is a duplicate of #823 which I needed to close to open this under the correct account for the CLA.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #822 🦕