Implement v1 reflection service and clean up integration#2704
Merged
JamesNK merged 4 commits intogrpc:masterfrom Mar 27, 2026
Merged
Implement v1 reflection service and clean up integration#2704JamesNK merged 4 commits intogrpc:masterfrom
JamesNK merged 4 commits intogrpc:masterfrom
Conversation
JamesNK
requested review from
a team,
BrennanConroy,
ReubenBond and
adityamandaleeka
BrennanConroy
approved these changes
Mar 26, 2026
This was referenced Apr 30, 2026
Closed
Open
This was referenced May 1, 2026
Bump the nuget-production-dependencies group with 22 updates
Mide69/Open-Telementry-project-demo#277
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1886
This pull request adds support for the v1 version of the gRPC server reflection protocol alongside the existing v1alpha version. It updates dependency management, service registration, and endpoint mapping to support both reflection versions, and includes the official proto definitions for both versions.
Support for gRPC Reflection v1 and v1alpha:
reflection.protofiles for both v1 (Proto/grpc/reflection/v1/reflection.proto) and v1alpha (Proto/grpc/reflection/v1alpha/reflection.proto), and configured the project to generate C# code for both usingGrpc.Tools. [1] [2] [3]ReflectionServiceImpl(v1alpha) andReflectionV1ServiceImpl(v1) in dependency injection and endpoint routing, so both reflection APIs are available. [1] [2]Service Registration and Code Structure Improvements:
ResolvedServiceDescriptors) used by both reflection implementations, reducing duplication and improving efficiency. [1] [2]CompositeEndpointConventionBuilderto allow endpoint conventions to be applied to both reflection endpoints simultaneously, simplifying endpoint configuration for consumers. [1] [2]