This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Plus sign (+) in selector failed#83
Closed
iamvdo wants to merge 1 commit intohail2u:masterfrom
Closed
Conversation
hail2u
added a commit
that referenced
this pull request
Nov 3, 2016
If white spaces around `\>`, `\+`, and `\~` in descendant combinator are removed, this selector may transform into the sequence of selectors. This will broke selector completely. These should be preserved. This resolves #83.
Owner
|
Thanks! Escaping in selectors is tough... This bug was fixed in 805049e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a combinator as part of the class name, minifier fails.
This PR adds a failure test.
Related: iamvdo/pleeease#80