Skip to content

fix(rust) recognize include_bytes! macro#3541

Merged
joshgoebel merged 1 commit intohighlightjs:mainfrom
Serial-ATA:include_bytes_macro
May 23, 2022
Merged

fix(rust) recognize include_bytes! macro#3541
joshgoebel merged 1 commit intohighlightjs:mainfrom
Serial-ATA:include_bytes_macro

Conversation

@Serial-ATA
Copy link
Copy Markdown
Contributor

@Serial-ATA Serial-ATA commented May 22, 2022 •
edited
Loading

Changes

Change builtin include_bin to include_bytes, as the former doesn't exist.

Checklist

  • Added markup tests, or they don't apply here because it is a simple word correction.
  • Updated the changelog at CHANGES.md

@Serial-ATA Serial-ATA force-pushed the include_bytes_macro branch from 018a2b7 to 948b1d6 Compare May 22, 2022 16:27
@joshgoebel
Copy link
Copy Markdown
Member

joshgoebel commented May 22, 2022

Was the former deprecated then?

@Serial-ATA
Copy link
Copy Markdown
Contributor Author

Serial-ATA commented May 22, 2022

I've never known it to be bin, and bytes has been around since 1.0 so it's probably safe to assume that even if that was the name in the past, no one is using it anymore.

@joshgoebel
Copy link
Copy Markdown
Member

joshgoebel commented May 23, 2022

@Serial-ATA Thanks so much!

@joshgoebel joshgoebel merged commit 4dfb4ae into highlightjs:main May 23, 2022
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@Jimimaku Jimimaku mentioned this pull request Jul 28, 2024
Closed
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@soyabn09 soyabn09 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Serial-ATA @joshgoebel