Improvement: Remove phone number validation from the Proof of Delivery model#771
Merged
ymaheshwari1 merged 1 commit intohotwax:mainfrom Apr 27, 2026
Merged
Conversation
…y model Improvement: Remove phone number validation from the Proof of Delivery model
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes phone number validation and error display from the ProofOfDeliveryModal component, including the removal of the phone field from the Zod schema. Feedback was provided regarding a missing space in a logical expression for readability and a suggestion to use standard Zod string methods for email validation while maintaining trailing commas for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement: Remove phone number validation from the Proof of Delivery model
Related Issues
##769