-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Make client tests work without server feature #3790
Copy link
Copy link
Closed
Labels
A-testsArea: tests.Area: tests.C-refactorCategory: refactor. This would improve the clarity of internal code.Category: refactor. This would improve the clarity of internal code.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Description
Metadata
Metadata
Assignees
Labels
A-testsArea: tests.Area: tests.C-refactorCategory: refactor. This would improve the clarity of internal code.Category: refactor. This would improve the clarity of internal code.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Running
cargo test --features http1,http2,clientfails to compile because it uses some types only available when theserverfeature is also enabled. Fixing this would just require adding or adjusting#[cfg(feature = ...)]attributes, paying attention to the compiler error messages.For CI, the
ffijob can be adjusted to no longer enableserverwhen running the tests.