Conversation
035a728 to
5509cda
Compare
dbd7455 to
d9575c1
Compare
d9575c1 to
264de9e
Compare
mnocon
commented
Dec 23, 2021
| @@ -0,0 +1,148 @@ | |||
| #!/bin/bash | |||
Contributor
Author
There was a problem hiding this comment.
This file has been copied from https://github.com/ibexa/ci-scripts/blob/0.1/bin/prepare_project_edition.sh
264de9e to
74f17dc
Compare
74f17dc to
487a501
Compare
micszo
approved these changes
Jan 4, 2022
Contributor
micszo
left a comment
There was a problem hiding this comment.
Tested locally and works fine. 🎉
Thanks!
tomaszszopinski
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done:
travisexecutable is now renamed tociThe usage stays as before:
Or:
depending on Composer bin-dir setting.
2) Unused scripts have been removed:
update_dockerandcheck_cswere not really used and are not needed going forward (moving to GA)3) Regression Command has been adjusted:
ibexa/oss,ibexa/content,ibexa/experience,ibexa/commerce) and runs the tests that are defined thereprepare_project_editionscript to be delived by Composer scripts forced us to docomposer installinside every package - it was done this way to limit the amount of logic inside each Travis configuration file.With Github Actions we can do it differentlly, recipes style - each script will be kept in a separate directory and will be downloaded by the Github Actions job when needed. Thanks to it we don't have to perform
composer installinside packages anymore to run browser tests. This also means that we won't be updating the 0.1 branch once we fully leave Travis behind.