Skip to content

GitHub actions refactor#31

Merged
micszo merged 4 commits intomainfrom
github-actions-refactor
Jan 5, 2022
Merged

GitHub actions refactor#31
micszo merged 4 commits intomainfrom
github-actions-refactor

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Dec 9, 2021

Things done:

  1. The travis executable is now renamed to ci
    The usage stays as before:
vendor/bin/ci dependencies:link
vendor/bin/ci regression:run

Or:

bin/ci dependencies:link
bin/ci regression:run

depending on Composer bin-dir setting.
2) Unused scripts have been removed: update_docker and check_cs were not really used and are not needed going forward (moving to GA)
3) Regression Command has been adjusted:

  • it now opens a PR in the repository chosen by user (ibexa/oss, ibexa/content, ibexa/experience, ibexa/commerce) and runs the tests that are defined there
    Zrzut ekranu 2021-12-13 o 16 23 44
  1. Relying on the prepare_project_edition script to be delived by Composer scripts forced us to do composer install inside every package - it was done this way to limit the amount of logic inside each Travis configuration file.
    With Github Actions we can do it differentlly, recipes style - each script will be kept in a separate directory and will be downloaded by the Github Actions job when needed. Thanks to it we don't have to perform composer install inside packages anymore to run browser tests. This also means that we won't be updating the 0.1 branch once we fully leave Travis behind.

@mnocon mnocon force-pushed the github-actions-refactor branch 2 times, most recently from 035a728 to 5509cda Compare December 9, 2021 14:36
@mnocon mnocon force-pushed the github-actions-refactor branch 2 times, most recently from dbd7455 to d9575c1 Compare December 22, 2021 09:54
@mnocon mnocon force-pushed the github-actions-refactor branch from d9575c1 to 264de9e Compare December 23, 2021 09:30
@@ -0,0 +1,148 @@
#!/bin/bash
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnocon mnocon force-pushed the github-actions-refactor branch from 74f17dc to 487a501 Compare December 23, 2021 12:23
Copy link
Copy Markdown
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works fine. 🎉

Thanks!

@micszo micszo merged commit 4132a91 into main Jan 5, 2022
@micszo micszo deleted the github-actions-refactor branch January 5, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants