Fixed branch selection for excluding packages#56
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
micszo
approved these changes
Sep 14, 2022
Contributor
Author
|
Yes, I will do it when creating stable branches. We might be able to simplify it for v4 in the future:
But right now I'm not 100% sure we can rely on this logic, so I'd like to merge this hardcoded way first to see how to works in practice |
bogusez
approved these changes
Sep 15, 2022
tomaszszopinski
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Follow-up to #55 , only 9eb669c constains new code (0b7f22c has already been reviewed)
The current branch selection logic is flawed:
https://github.com/ibexa/$EDITION/1.3/composer.jsonis used - buthttps://github.com/ibexa/$EDITION/3.3/composer.jsonshould be used instead.https://github.com/ibexa/$EDITION/main/composer.jsonis used - buthttps://github.com/ibexa/$EDITION/master/composer.jsonshould be used instead.It worked in ibexa/content#53 because the PR base branch (3.3) is the same as the endpoint that should be used - but it fails in https://github.com/ezsystems/ezplatform-version-comparison/pull/79
I thought I could avoid harcoding the branches by doing some magic with Github env variables, but it's not possible - hardcoding it seems like the easiest solution.
Tested in https://github.com/ezsystems/ezplatform-version-comparison/pull/79