Added basic tests and fixed upgraded dependency issue#60
Merged
Conversation
mnocon
requested review from
bogusez,
katarzynazawada,
micszo and
tomaszszopinski
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Sep 23, 2022
Contributor
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Thanks for expanding CI coverage in this repo!
| { | ||
| public function testIsInitializable(): void | ||
| { | ||
| Assert::assertInstanceOf(RunRegressionCommand::class, new RunRegressionCommand()); |
Contributor
There was a problem hiding this comment.
That's a neat way of detecting changes in classes!
tomaszszopinski
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed the issues after #59
Because I was adding a new namespace for tests I've decided to get rid of the
Platformpart in all classes - to make it consistent with other DXP packages.I was able to write a meaningful test for the LinkDependenciesCommand, which tests the Command output.
For RunRegressionCommand I was not able to find the right balance - the Command does many interactions (Github API, filesystem changes, git repository changes) that require mocking all dependencies, which would result in a test very strictly coupled with the implementation. The test I've ended up adding would detect the issue that this PR fixes.
Also e1f1024 fixes small issue related to stable branches.