Skip to content

Removed hardcoded productVersion logic#61

Merged
micszo merged 1 commit intomainfrom
remove-hardcoded-version
Sep 30, 2022
Merged

Removed hardcoded productVersion logic#61
micszo merged 1 commit intomainfrom
remove-hardcoded-version

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Sep 30, 2022

Instead of having the logic hardcoded we ask GitHub whether the productVersion branch exists in the repository - if it does then we will use it, otherwise we will default to master.

Tested locally, the string(6) "VALUE" shows which branch will be used.

~/Desktop/repos/ci-scripts on remove-hardcoded-version !1 ?2 ❯ bin/ci regression:run                                                                                                                       took 4m 4s  14.17.0 at 10:09:12

 Please enter the Ibexa DXP version [4.2]:
 > 4.2

 Please enter the Ibexa DXP edition(s) [oss]:
 > oss

string(3) "4.2"
~/Desktop/repos/ci-scripts on remove-hardcoded-version !1 ?2 ❯ bin/ci regression:run                                                                                                                          took 6s  14.17.0 at 10:09:46

 Please enter the Ibexa DXP version [4.2]:
 > 4.3

 Please enter the Ibexa DXP edition(s) [oss]:
 > oss

string(6) "master"
~/Desktop/repos/ci-scripts on remove-hardcoded-version !1 ?2 ❯ bin/ci regression:run                                                                                                                          took 3s  14.17.0 at 10:09:51

 Please enter the Ibexa DXP version [4.2]:
 > 3.3

 Please enter the Ibexa DXP edition(s) [oss]:
 > oss

string(3) "3.3"
~/Desktop/repos/ci-scripts on remove-hardcoded-version !1 ?2 ❯ bin/ci regression:run                                                                                                                         took 13s  14.17.0 at 10:10:05

 Please enter the Ibexa DXP version [4.2]:
 > 4.3

 Please enter the Ibexa DXP edition(s) [oss]:
 > content

string(6) "master"
~/Desktop/repos/ci-scripts on remove-hardcoded-version !1 ?2 ❯ bin/ci regression:run                                                                                                                          took 5s  14.17.0 at 10:10:12

 Please enter the Ibexa DXP version [4.2]:
 > 4.4

 Please enter the Ibexa DXP edition(s) [oss]:
 > content

string(6) "master"

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@micszo micszo merged commit dfaec8a into main Sep 30, 2022
@micszo micszo deleted the remove-hardcoded-version branch September 30, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants