Skip to content

Added visual testing#63

Merged
micszo merged 2 commits intomainfrom
add-percy-support
Dec 8, 2022
Merged

Added visual testing#63
micszo merged 2 commits intomainfrom
add-percy-support

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Oct 11, 2022

JIRA: https://issues.ibexa.co/browse/IBX-3902

This PR adds two things:

  1. Package requesting the setup will be always added to composer.json (triggering a build from ibexa/visual-testing will cause it to be added to composer.json and installed automatically)
  2. Percy env variable is set, based on project edition and version (commerce ^4.3.x-dev -> 4.3/commerce)

@mnocon mnocon force-pushed the add-percy-support branch from e02b02b to fe31ca2 Compare October 26, 2022 15:01
@mnocon mnocon marked this pull request as ready for review October 26, 2022 15:04
@mnocon mnocon force-pushed the add-percy-support branch from 20171bb to 2d9de6c Compare October 26, 2022 15:23
@mnocon mnocon changed the title Percy Added visual testing Oct 27, 2022
@mnocon mnocon force-pushed the add-percy-support branch from 2d9de6c to 3e1873c Compare December 7, 2022 12:55
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micszo micszo merged commit da4ab76 into main Dec 8, 2022
@micszo micszo deleted the add-percy-support branch December 8, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants