Conversation
mnocon
requested review from
bogusez,
jwibexa,
katarzynazawada,
micszo and
tomaszszopinski
micszo
approved these changes
Jul 4, 2023
Contributor
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Thanks!
Don't we need it in 4.5.x-dev also? 🙂
Contributor
Author
|
Good catch, we do 😄 Added in 38ec571 |
|
Kudos, SonarCloud Quality Gate passed!
|
bogusez
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issues with the latest Docker images we had (ibexa/headless#3)
The newer images have newer Git version, which contains new security setting. More information:
https://github.blog/2022-04-12-git-security-vulnerability-announced/
https://stackoverflow.com/questions/71849415/i-cannot-add-the-parent-directory-to-safe-directory-in-git
Without marking the /var/www dir as safe the git operations fail (silently! which is the worst part) - and without a working git repository the recipes installation fails as well (recipes are not applied).
Tested in ibexa/headless#4