Moved adding dependencies to the last part of installation phase#76
Merged
Moved adding dependencies to the last part of installation phase#76
Conversation
mnocon
force-pushed
the
move-dependencies
branch
from
12823f0 to
0bb84c5
Compare
mnocon
force-pushed
the
move-dependencies
branch
from
0bb84c5 to
e3468c0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mnocon
requested review from
bogusez,
jwibexa,
katarzynazawada,
micszo and
tomaszszopinski
tomaszszopinski
approved these changes
Aug 21, 2023
bogusez
approved these changes
Aug 21, 2023
micszo
approved these changes
Aug 21, 2023
mnocon
added a commit
that referenced
this pull request
Dec 4, 2023
* Moved adding dependencies to the last part of installation phase * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
it's not currently possible to add a dependency (using dependencies.json) for
ibexa/behatandibexa/dockerpackages:they are added during the "adding dependencies" phase, but after this phase they are added again (in the 4.6.x-dev version).
Example affected build: https://github.com/ibexa/commerce/actions/runs/5900504035/job/16004881059
You can see that the dependency is downgraded:
Only 4.6 is affected, this is a bug I've added in #73
My solution is to move the phases around:
behatanddockerpackages first (with--no-update)--no-update)composer update --no-scripts)Tested in:
ibexa/commerce#348
https://github.com/ibexa/taxonomy/pull/40