Fixed PR from my prev PR #574#578
Open
shramanb113 wants to merge 3 commits intointernetarchive:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability and scalability of the archiver by removing
fragile timing assumptions, eliminating dead code execution, and replacing
a spin-wait in the rate limiter.
Changes
Replaces a
time.Sleepused to avoid a known race condition betweenrouter.Run()andpage.Navigate()with a deterministic synchronizationmechanism.
When asset capture and crawling are disabled, the response body was fully
discarded but processing continued, leading to MIME detection and buffering
on an already-consumed stream. An early return is added to avoid unnecessary
work and ensure correct behavior.
Replaces a busy-wait loop that periodically re-acquired a mutex with a
time-based wait calculated from the token refill rate.