fix flake8 build error due to missing stacklevel argument for warn method#554
Merged
imatiach-msft merged 1 commit intointerpretml:mainfrom Mar 6, 2023
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 62 62
Lines 4094 4094
=======================================
Hits 3596 3596
Misses 498 498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gaugup
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing gated builds fail due to new errors:
These warnings seem to have been added to the newer releases of flake8-bugbear extension package to flake8.
This PR fixes the error by explicitly setting the stacklevel argument on the warn method call. It seems it is recommended to set it to level 2 as it creates better warning messages by excluding the warn method itself from the printed stacktrace which can be confusing.