Add support for tuples#29
Conversation
|
Just wondering/nit, pytimeparse2 doesn't seems maintained as well (last release in 2023) and quite 'small' 19 (stars on github), shouldn't we just switch to something 'bigger' like dateparser ? It's not 100% compatible but covers most of cases. |
I'm definitely open to other packages (though at this point I'm a little tempted to just write our own logic), but it doesn't seem like dateparser does what we need. pytimeparse + pytimeparse2 are used solely to parse time deltas like "1 hour", "1d5h", "05:23", etc. It doesn't appear that dateparser will parse time deltas at all. pytimeparse has many more forks and stars than pytimeparse2, but it was last released in 2018 and doesn't have some features that pytimeparse2. So, I'm not sure of what would be a better option than pytimeparse2, but I'd be happy to switch packages in a future PR if we can identify a better candidate. |
This PR adds support for tuples in ImplicitDict objects.
It also switches from unmaintained pytimeparse to pytimeparse2.