Skip to content

Add support for tuples#29

Merged
BenjaminPelletier merged 7 commits intointeruss:mainfrom
BenjaminPelletier:tuple-support
Apr 29, 2026
Merged

Add support for tuples#29
BenjaminPelletier merged 7 commits intointeruss:mainfrom
BenjaminPelletier:tuple-support

Conversation

@BenjaminPelletier
Copy link
Copy Markdown
Member

@BenjaminPelletier BenjaminPelletier commented Apr 19, 2026

This PR adds support for tuples in ImplicitDict objects.

It also switches from unmaintained pytimeparse to pytimeparse2.

@the-glu
Copy link
Copy Markdown
Contributor

the-glu commented Apr 22, 2026

Just wondering/nit, pytimeparse2 doesn't seems maintained as well (last release in 2023) and quite 'small' 19 (stars on github), shouldn't we just switch to something 'bigger' like dateparser ? It's not 100% compatible but covers most of cases.

Copy link
Copy Markdown
Contributor

@barroco barroco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comment from @the-glu before merging.

@BenjaminPelletier
Copy link
Copy Markdown
Member Author

Just wondering/nit, pytimeparse2 doesn't seems maintained as well (last release in 2023) and quite 'small' 19 (stars on github), shouldn't we just switch to something 'bigger' like dateparser ? It's not 100% compatible but covers most of cases.

I'm definitely open to other packages (though at this point I'm a little tempted to just write our own logic), but it doesn't seem like dateparser does what we need. pytimeparse + pytimeparse2 are used solely to parse time deltas like "1 hour", "1d5h", "05:23", etc. It doesn't appear that dateparser will parse time deltas at all. pytimeparse has many more forks and stars than pytimeparse2, but it was last released in 2018 and doesn't have some features that pytimeparse2. So, I'm not sure of what would be a better option than pytimeparse2, but I'd be happy to switch packages in a future PR if we can identify a better candidate.

@BenjaminPelletier BenjaminPelletier merged commit c2cdf25 into interuss:main Apr 29, 2026
7 checks passed
@BenjaminPelletier BenjaminPelletier deleted the tuple-support branch April 29, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants