[uss_qualifier] Examine pre-existing notifications for SCD0090/95#1170
Merged
BenjaminPelletier merged 1 commit intointeruss:mainfrom Sep 25, 2025
Merged
Conversation
Member
Author
|
Update: that was the issue and it is now resolved. |
barroco
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily enhances SCD0090 and SCD0095 testing by checking pre-existing notifications before the flight planning action so that those notifications can be definitively excluded as notifications that may have been triggered by the flight planning action. This makes it possible to incorporate more robust behavior in the presence of clock skew between uss_qualifier and USSs under test (previously, clock skew could have caused by false positives and false negatives). Finally, a bug observed in the wild is fixed for a timing edge case (where
new_notificationswasn't populated with all clients under certain conditions).