[uss_qualifier] migrate planning_area_resource to new volume resource#1192
Merged
BenjaminPelletier merged 2 commits intointeruss:mainfrom Oct 8, 2025
Merged
Conversation
4 tasks
Shastick
force-pushed
the
planning-area-uses-volume
branch
5 times, most recently
from
79fa598 to
d041b1c
Compare
Member
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
Looks good -- just two comments
Comment on lines
+46
to
+48
| specification: PlanningAreaSpecification, | ||
| volume: VolumeResource, | ||
| resource_origin: str, |
Member
There was a problem hiding this comment.
resource_origin is an infrastructure argument and should [come before](
Suggested change
| specification: PlanningAreaSpecification, | |
| volume: VolumeResource, | |
| resource_origin: str, | |
| specification: PlanningAreaSpecification, | |
| resource_origin: str, | |
| volume: VolumeResource, |
| from monitoring.uss_qualifier.resources.volume import VolumeResource | ||
|
|
||
|
|
||
| class PlanningAreaSpecification(ImplicitDict): |
Member
There was a problem hiding this comment.
Let's update the description rather than removing it
Shastick
force-pushed
the
planning-area-uses-volume
branch
2 times, most recently
from
1687d4e to
9d3dcbe
Compare
Shastick
force-pushed
the
planning-area-uses-volume
branch
from
9d3dcbe to
70fd34a
Compare
BenjaminPelletier
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
PlanningAreaResourceto wrap the recently introducedVolumeResourceas a dependency:The PR leaves a few TODOs related to the resolution of the volume resource, which will be tackled later on.
Note that this is a breaking change of relevant resource configurations.
Part of #1053