[shell-lint] Pin shell check#1241
Merged
barroco merged 5 commits intointeruss:mainfrom Oct 17, 2025
Merged
Conversation
5115cf0 to
2c0f4c5
Compare
2c0f4c5 to
32c5ad2
Compare
Member
|
Note that #1235 also incidentally pins shellcheck to fix the problem as well |
ed7583b to
84327af
Compare
BenjaminPelletier
approved these changes
Oct 16, 2025
c69c952 to
fcb73e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins shellcheck to prevent unmanaged linter updates to the stable version.
For some reason, #1230 (https://github.com/interuss/monitoring/pull/1230/files#diff-9278c1479c4b147bf3980575eb5332e61116e358bd9d81472eb3a456f812c3bbR3) introduced a linter error.
v0.8.0, v0.9.0, v0.10.0 and v0.11.0 are breaking with the same error. It seems that the latest stable version is the correct one we use to use before that latest upgrade last night.
Though, that doesn't explain why #1230 made it to the main branch.