[uss_qualifier] introduce distance error tolerance for some DisplayProviderBehavior#1259
Merged
BenjaminPelletier merged 1 commit intointeruss:mainfrom Oct 27, 2025
Merged
Conversation
b18fdb5 to
965fc14
Compare
| # than uss_qualifier. We thus accept an error margin of 0.7% around distance limits and thresholds | ||
| # to avoid failing USSes for minor differences in precision whenever the relevant standard is not | ||
| # prescriptive in that regard. | ||
| DISTANCE_ERROR_TOLERANCE_PERCENT = 0.007 |
Member
There was a problem hiding this comment.
0.007 is presumably the DISTANCE_ERROR_TOLERANCE_FRACTION that we want in order to achieve a DISTANCE_ERROR_TOLERANCE_PERCENT of 0.7
Suggested change
| DISTANCE_ERROR_TOLERANCE_PERCENT = 0.007 | |
| DISTANCE_ERROR_TOLERANCE_FRACTION = 0.007 |
or
Suggested change
| DISTANCE_ERROR_TOLERANCE_PERCENT = 0.007 | |
| DISTANCE_ERROR_TOLERANCE_PERCENT = 0.7 |
965fc14 to
94fa99e
Compare
ad2dc34 to
e95c4b7
Compare
…oviderBehavior checks
e95c4b7 to
915c5e4
Compare
BenjaminPelletier
approved these changes
Oct 27, 2025
| QueryType.F3411v22aUSSGetFlightDetails, | ||
| ] | ||
|
|
||
| # Different spherical models have different precisions: implementations may use a different model |
Member
There was a problem hiding this comment.
nit: it's not different spherical models, it's just different models for the shape of the Earth. Specifically, the more-accurate ellipsoidal model can be off from our less-accurate spherical model by a little under 0.7%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an error margin when checking for specific USS behavior around specific thresholds, such as the maximum diagonal of an observed area.
This updates the display provider maximum allowed area observation
(Updating other checks such as the clustering thresholds require some unrelated adaptations and will happen in a separate PR)
Notes
Some context from a Slack thread: