[uss_qualifier/scenarios/uss_down] Only clean op intents when some were created#1425
Merged
mickmis merged 1 commit intointeruss:mainfrom Apr 20, 2026
Merged
Conversation
mickmis
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1422 by first making sure the problem would have been caught by basedpyright by adding a type annotation to
areain_clear_op_intents-- this results in a basedpyright finding that "None" is not assignable to "Volume4D" (reportArgumentType). This finding is then resolved by only calling _clear_op_intents from cleanup when one or more op intents were actually created during the scenario (self.scenario_execution_max_extents is not None).