feat: enhance grammar specification and documentation system#14
Merged
Simon-McIntosh merged 13 commits intoiterorganization:mainfrom Nov 20, 2025
Merged
feat: enhance grammar specification and documentation system#14Simon-McIntosh merged 13 commits intoiterorganization:mainfrom
Simon-McIntosh merged 13 commits intoiterorganization:mainfrom
Conversation
- Add comprehensive grammar specification with detailed field schemas and validation rules - Introduce generic_physical_bases vocabulary to prevent ambiguous names - Enhance documentation requirements with inline links, equations, and formatting standards - Update project configuration with new dependencies and development tools - Improve grammar reference documentation generation - Modernize codebase structure and validation logic - Add tokamak parameters and vocabulary management tools - Update development guidelines and agent documentation This major update establishes a more robust foundation for IMAS standard names with enhanced validation, and comprehensive documentation generation.
…, eliminating manual formatting exclusions
- Regenerate constants and schemas - Add description validation - Update AGENTS.md documentation
…vocation and remove generated files from version control.
…vocation and remove generated files from version control.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Simon-McIntosh
had a problem deploying
to
github-pages
GitHub Actions
Failure
Simon-McIntosh
added a commit
that referenced
this pull request
Apr 28, 2026
Compose-level NC-32 patch in imas-codex (47ed76eb) prevented new _on_ggd compositions, but the vocab attach pipeline kept resurfacing pre-existing registry entries with this suffix. W25D + W26B evidence: 13 attach-through names scoring 0.5-0.6 dragged MHD domain mean to 0.645 (YELLOW boundary). Standard names should be coordinate-system agnostic. The DD ggd/* path subtree encodes coordinate metadata at the schema level, not the physics name level. This PR retires the _on_ggd suffix family by: - Deleting 4 physical bases with canonical non-GGD twins: energy_radial_diffusivity_on_ggd (twin: energy_radial_diffusivity) momentum_diffusivity_on_ggd (twin: momentum_diffusivity) momentum_radial_diffusivity_on_ggd (twin: momentum_radial_diffusivity) particle_radial_diffusivity_on_ggd (twin: particle_radial_diffusivity) - Deleting on_ggd unary postfix operator from operators.yml - Regenerating model_types.py and constants.py (ON_GGD enum removed) - Updating test expectations (2 parametrized entries removed) All 1106 tests pass. Zero test count delta (removed 2 parametrized entries, no new tests needed since canonical twins remain). Cross-references: - imas-codex commit 47ed76eb (NC-32 compose-level prohibition) - W26B verdict report (this PR motivation) - W25D MHD domain rotation evidence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This major update establishes a more robust foundation for IMAS standard names with enhanced validation and comprehensive documentation generation.
Key Changes
Grammar System Enhancements
Documentation Improvements
New Features
Code Quality
Files Changed
Breaking Changes
This update provides the foundation for more robust standard name validation and management while maintaining backward compatibility for existing valid names.