fix another potential source of undefined behavior#283
Merged
mdadams merged 2 commits intojasper-software:masterfrom Mar 18, 2021
Merged
fix another potential source of undefined behavior#283mdadams merged 2 commits intojasper-software:masterfrom
mdadams merged 2 commits intojasper-software:masterfrom
Conversation
if prec is 31, this leads to an undefined shift
Collaborator
@alex Please change the "1U" to "JAS_CAST(uint_fast32_t, 1)" and I can merge this PR. Since the result is effectively being computed in uint_fast32_t (not unsigned), I think that this would be slightly better. |
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if prec is 31, this leads to an undefined shift