Fix crash when freeing JPEG comments.#37
Merged
mdadams merged 2 commits intojasper-software:mainfrom Aug 22, 2025
Merged
Conversation
A pointer to the local `xvcmt` buffer was stored in the global `comment`. 9c2e7ae added `if (comment) free(comment);` which causes a segfault. Can be reproduced by opening a second JPEG after cropping and saving a JPEG.
It might be possible for `comment` to not be NULL, resulting in a memory leak after changing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pointer to the local
xvcmtbuffer was stored in the globalcomment. 9c2e7ae addedif (comment) free(comment);which causes a segfault.Can be reproduced by opening a second JPEG after cropping and saving a JPEG.
The second patch may or may not be needed, and could be removed if
commentis guaranteed to always be NULL. It just makes sense to free and avoid possible leaks.