Skip to content

Exclude org.jenkins-ci:task-reactor from enforceBytecodeVersion#95

Merged
jglick merged 1 commit intojenkinsci:masterfrom
jglick:task-reactor
Feb 19, 2018
Merged

Exclude org.jenkins-ci:task-reactor from enforceBytecodeVersion#95
jglick merged 1 commit intojenkinsci:masterfrom
jglick:task-reactor

Conversation

@jglick
Copy link
Copy Markdown
Member

@jglick jglick commented Feb 14, 2018

After jenkinsci/lib-task-reactor#2 in 2.105, plugins using java.level=7 need this in order to build.

@reviewbybees

@jglick jglick requested a review from oleg-nenashev February 14, 2018 21:51
jglick added a commit to jglick/groovy-plugin that referenced this pull request Feb 14, 2018
@daniel-beck
Copy link
Copy Markdown
Member

@jglick Is there a real use case to be java.level=7 when you're 2.105+?

@oleg-nenashev
Copy link
Copy Markdown
Member

@jglick Do you mean the build on CI when you specify jenkinsVersions? If yes, my suggestion would be to to modify Pipeline Library a bit to automatically set java.level according to the target version. Modifying Plugin POM just to workaround it seems to be lame

Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 if I understand the use-case correctly. Instead of that, java.level should be defined accordingly to the Jenkins core. We could just add a profile to plugin-pom, which bumps java.level if jenkins.version is beyond 2.54

@oleg-nenashev
Copy link
Copy Markdown
Member

Well, there is no trivial way to implement my suggestion above, will think about non-trivial ones

@jglick
Copy link
Copy Markdown
Member Author

jglick commented Feb 16, 2018

there is no trivial way to implement my suggestion above

No, there is not. This is the only practical solution. And it is harmless—the dep is picked up from core, so the plugin cannot be doing anything wrong.

See #91.

Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 since there is no quick ways to do what I propose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants