Change logging level parsing to match documentation#16
Open
jorge-martinez-scopely wants to merge 5 commits intojfversluis:mainfrom
Open
Change logging level parsing to match documentation#16jorge-martinez-scopely wants to merge 5 commits intojfversluis:mainfrom
jorge-martinez-scopely wants to merge 5 commits intojfversluis:mainfrom
Conversation
The "-f" was being added after the path, causing the path to not be recognised as such and the -f triggering an unrecognized command or argument error
Same as the previous commit (for dotnet.ts) but for index.js The "-f" was being added after the path, causing the path to not be recognised as such and the -f triggering an unrecognized command or argument error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging level option is being parsed as "log-level", but both the documentation and some sort of validator say it should be "logLevel".
This PR changes both places where the code tries to get "log-level" to instead use "logLevel".