fix(bazqux): Handle missing url on Reader API subscriptions#2081
Merged
Conversation
jocmp
changed the title
jocmp
force-pushed
the
jc/reader-subscription-url-fallback
branch
from
2baa14a to
1792923
Compare
jocmp
force-pushed
the
jc/reader-subscription-url-fallback
branch
from
1792923 to
986f6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BazQux omits
urlon subscriptions and embeds the feed URL inidasfeed/<url>. Fall back to that whenurlis null. Matches NNW (ReaderAPISubscription.swiftvar url).Ref