refactor(repo): remove dead and internal-only public exports#124
refactor(repo): remove dead and internal-only public exports#124zrosenbauer merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
🦋 Changeset detectedLatest commit: 53b0daa The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR reduces the public API surface across packages by removing multiple exports and an entire module. In packages/bundler, several value and type exports (autoloader generators, config mappers/resolvers, and a scan utility) were removed from the entry. In packages/core, four package.json export subpaths (./config, ./format, ./store, ./project) were removed and the runtime dependency jsonc-parser was dropped. In packages/utils, the redact build entry, its export subpath, the SENSITIVE_PATTERNS constant, sanitize() function, and their test file were deleted; the tsdown config entry for redact was also removed. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
Remove sub-entrypoints and barrel exports that are either never consumed or only used internally within their own package: - @kidd-cli/core: remove ./config, ./format, ./store, ./project (zero imports) - @kidd-cli/utils: remove ./redact sub-entrypoint (zero cross-package imports) - @kidd-cli/bundler: trim index to only externally consumed exports (build, compile, watch, resolveTargetLabel, createAutoloadPlugin + types) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
- Delete `packages/utils/src/redact.ts` and its tests (zero consumers) - Remove `redact` entry from utils tsdown config - Remove dead `jsonc-parser` dependency from core - Restore `lib/config` as internal-only module (used by runtime via dynamic import) - Update changeset description Co-Authored-By: Claude <noreply@anthropic.com>
6600505 to
9eb0715
Compare
Fix `jsdoc-js(multiline-blocks)` lint errors in `use-key-binding.ts` caught by CI's oxlint version. Co-Authored-By: Claude <noreply@anthropic.com>
Summary
@kidd-cli/core(./config,./format,./store,./project) — zero imports anywhere in the codebase@kidd-cli/utils/redactsub-entrypoint — zero cross-package imports (@pinojs/redactis used directly instead)@kidd-cli/bundlerbarrel to only externally consumed exports:build,compile,watch,resolveTargetLabel,createAutoloadPlugin+ consumed types. Removes 8 internal-only functions (generateAutoloaderParts,generateStaticAutoloader,mapToBuildConfig,mapToWatchConfig,detectBuildEntry,normalizeCompileOptions,resolveConfig,scanCommandsDir) and unused types (AsyncBundlerResult,BundlerResult,ResolvedBuildOptions,ResolvedBundlerConfig,ResolvedCompileOptions,ScanResult,ScannedDir,ScannedFile,StaticAutoloaderParts)No source files, tests, or internal implementations were changed — only the public-facing export surface.
Test plan
pnpm checkpasses (typecheck + lint + format)pnpm testpasses (881 tests across all packages)