Fix war file path as argument for jetty runner#527
Merged
olleolleolle merged 2 commits intojruby:masterfrom Oct 23, 2022
Merged
Fix war file path as argument for jetty runner#527olleolleolle merged 2 commits intojruby:masterfrom
olleolleolle merged 2 commits intojruby:masterfrom
Conversation
Contributor
Author
|
No sure if I have to commit the generated jar file |
kares
reviewed
Oct 22, 2022
kares
reviewed
Oct 22, 2022
Member
kares
left a comment
There was a problem hiding this comment.
LGTM, the .jar commit should not be necessary (unfortunately it kind of is atm).
The .jar changes so rarely that it's not part of rake release to rake build the .jar.
But I think it's also a feature as it allows using Warbler from github: 'jruby/warbler' git.
For security reasons and to make sure compilation happens with the tools (Java version) intended it's best if it's performed by a maintainer (as a follow up of merging the PR).
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
olleolleolle
approved these changes
Oct 23, 2022
Member
olleolleolle
left a comment
There was a problem hiding this comment.
Thanks @JesseChavez!
Thanks @kares for a clear review!
I will make a sign-post Issue about "regenerate the JAR".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the war file path that is given to the embedded Jetty runner.
Before this change:
(only works in older jetty version older than
9.4.32.v20200930)After this change:
(works for newer jetty versions starting with
9.4.32.v20200930, includes jetty 10.x)