Normalize channel names in list numerics#320
Merged
ItsOnlyBinary merged 1 commit intokiwiirc:masterfrom Feb 17, 2022
Merged
Conversation
Closes thelounge/thelounge#4126 Some servers may not write channel names with consistent casing. For example, Bahamut writes RPL_NAMREPLY using the real case of the channel, while RPL_ENDOFNAMES uses the case of the client's command.
progval
force-pushed
the
normalize-cache-key
branch
from
80feaed to
7d65966
Compare
MaxLeiter
approved these changes
Feb 13, 2022
ItsOnlyBinary
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes thelounge/thelounge#4126
Some servers may not write channel names with consistent casing.
For example, Bahamut writes RPL_NAMREPLY using the real case of the channel,
while RPL_ENDOFNAMES uses the case of the client's command.
For example, when joining a channel named
#ValTest: