Add missing 'account' property on 'ctcp response' and 'tagmsg'#360
Merged
MaxLeiter merged 2 commits intokiwiirc:masterfrom Jun 9, 2023
Merged
Add missing 'account' property on 'ctcp response' and 'tagmsg'#360MaxLeiter merged 2 commits intokiwiirc:masterfrom
MaxLeiter merged 2 commits intokiwiirc:masterfrom
Conversation
brunnre8
reviewed
Jun 7, 2023
Contributor
brunnre8
left a comment
brunnre8
left a comment
There was a problem hiding this comment.
For what it's worth, change looks good to me.
The documentation could use an update though, docs/events.md is horribly out of sync with the reality there.
But that can be done in a follow up patch I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.