`fake` and friends don't work on existing subscriptions

[textgoeshere]

Just following up on #6.

If the subscription already exists then its registration is already assigned a (real) listener. Calling fake only affects subsequent registrations. This is particularly a challenge where you are working with global listeners because you can't usually control their load order to get the fake in before the subscription.

Here's a failing spec that illustrates the issue: https://gist.github.com/14d09819e2c0ccb1bd23.

Assuming this isn't by design ;), do you like the idea of adding a step to walk over the existing registrations, memoize their broadcasters, and replace them with FakeBroadcaster? And reversing that on restore.

[krisleech]

It isn't by design :)

I assumed that Wisper pulls the broadcaster from the configuration at the time of broadcast, but it does not, it sets a broadcaster at the time of registration.

The only issue I can see with the idea of stepping over the registrations is that there is no public API for accessing registrations. You can get global registrations via Wisper::GlobalListeners.registrations but again this isn't part of the public API.

[zlw]

I also encountered this problem. I needed to get #inline to work with global subscriptions.
zlw@717917c - it works, but as you said - this is not part of public API 😞

Can we think of something to allow this in a nice and clean manner? For now we have to use my fork in our company projects and we'd really like to be able to use official release instead.

[a14m]

so is there an "official" way of making fake! and inline! working with global listeners?

[joemsak]

Using @zlw's fork solves my issue