[IMP] web_dark_mode Full CSS customizations#1
Closed
ljmnoonan wants to merge 164 commits intolambdao-dev:18.0-mig-web_dark_modefrom
Closed
[IMP] web_dark_mode Full CSS customizations#1ljmnoonan wants to merge 164 commits intolambdao-dev:18.0-mig-web_dark_modefrom
ljmnoonan wants to merge 164 commits intolambdao-dev:18.0-mig-web_dark_modefrom
Conversation
On tree views the widget will be initialized once. Without this change the value displayed is always the same. Now anchor's text is computed on rendering.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-14.0/web-14.0-web_widget_url_advanced Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_url_advanced/
Currently translated at 100.0% (4 of 4 strings) Translation: web-16.0/web-16.0-web_dark_mode Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dark_mode/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: web-16.0/web-16.0-web_dark_mode Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dark_mode/tr/
Currently translated at 100.0% (4 of 4 strings) Translation: web-16.0/web-16.0-web_dark_mode Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dark_mode/es/
Currently translated at 50.0% (2 of 4 strings) Translation: web-16.0/web-16.0-web_dark_mode Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dark_mode/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: web-16.0/web-16.0-web_dark_mode Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dark_mode/it/
Also, change asset bundle loading from 'prepend' to 'before' This is in line with Odoo's own way of doing it.
If you go to any activity view and hover over an empty cell you will notice that without this fix the the on hover background of empty cells (.o_activity_empty_cell) set by $component-active-bg which is itself set as mix($o-action, $o-gray-100, 20%) through $o-component-active-bg completely ignores the overrides we set in primary_variables.dark.scss. This is because the assets for that view are lazy loaded, so we need to include our override bundles in the lazy bundle.
Just general customizations of BS variables to bring them in line with our style
Add secondary_variables override to get rid of colors that don't jive well with the dark background. Unfortunately this does introduce an issue where if you have many calendar users, you can run out of colors This issue exists in the enterprise dark mode as well, so hopefully it will be fixed.
Set the background color to be darker and tone down the border around it. The styling for the border is borrwed from the style of .o-mail-Composer-bg
Set attachment image background to white and fix the column background when hovering with a draggable card
ljmnoonan
force-pushed
the
18.0-web_dark_mode
branch
from
90a01e9 to
7aea54e
Compare
ljmnoonan
added a commit
to Pyxiris/web
that referenced
this pull request
Oct 21, 2025
web_dark_mode is not merged yet. OCA#3267 And my CSS overhaul here: lambdao-dev#1
ljmnoonan
added a commit
to Pyxiris/web
that referenced
this pull request
Oct 21, 2025
web_dark_mode is not merged yet. OCA#3267 And my CSS overhaul here: lambdao-dev#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In your PR on OCA/web, @len-foss mentioned that the CSS would need some polish. This PR fully adapts the UI to dark mode and reorganizes assets, bundles, and their loading order according to Odoo's conventions.
The main colors are taken mostly from VScode's Dark Modern theme.
Please let me know if you would like me to change anything or if you find any mistakes!