This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Dependabot, code coverage, and go mod tidy#12
Merged
beautifulentropy merged 3 commits intomainfrom Dec 1, 2021
Merged
Conversation
Member
|
I'm aware of the time.Tick problem. Lints are out of scope for the issue, you can go ahead and remove them for now. Thanks! |
beautifulentropy
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice job Amir:
Anyway, did a
go mod tidy, added depandabot, and github actions for codecov & linting@beautifulentropy I'm not sure what to do about it complaining of
var ticks = time.Tick(5 * time.Second). Feel free to commit on top of this branch or tell me what I should do w/ it.