This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Add Redis Auth and mTLS support#14
Merged
beautifulentropy merged 19 commits intomainfrom Dec 9, 2021
Merged
Conversation
…attempts to connect
aaomidi
reviewed
Dec 7, 2021
jsha
reviewed
Dec 8, 2021
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
I think we don't need auth-enable and tls-enable flags. We should treat auth and TLS as always-on features, and fail out if the needed flags (username, password, certs, etc) are not provided.
|
(related to the above- I believe the code as currently written would allow you to pass the cert file and key file flags, but if you failed to also pass the enablement flags, it would silently ignore those, which would be bad) |
Member
Author
Yeah, I can totally see how that would be confusing. |
jsha
approved these changes
Dec 9, 2021
beautifulentropy
added a commit
that referenced
this pull request
Dec 10, 2021
This commit adds support for Redis Auth and mTLS to both `attache-check` and `attache-control`. The number of configuration flags being added in this commit necessitated a little bit of reorganization and cleanup to the config validation code. Similar to the aforementioned config cleanup, the large amount of new vars being added to the `example/job-specification.hcl` necessitated the creation of an `hcl` vars-file at `example/vars-file.hcl`. All new vars being added to the job specification have been fully commented as well. Fixes #7 Fixes #8 Part of #11
beautifulentropy
added a commit
that referenced
this pull request
Dec 10, 2021
This reverts commit 9ec5aeb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for Redis Auth and mTLS to both
attache-checkandattache-control. The number of configuration flags being added in this commitnecessitated a little bit of reorganization and cleanup to the config validation
code.
Similar to the aforementioned config cleanup, the large amount of new vars being
added to the
example/job-specification.hclnecessitated the creation of anhclvars-file atexample/vars-file.hcl. All new vars being added to the jobspecification have been fully commented as well.
Fixes #7
Fixes #8
Part of #11