This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Vendor dependencies#23
Merged
beautifulentropy merged 1 commit intomainfrom Jan 21, 2022
Merged
Conversation
aarongable
reviewed
Jan 21, 2022
jsha
approved these changes
Jan 21, 2022
aarongable
reviewed
Jan 21, 2022
| run: | | ||
| go test -mod=readonly -v -race -covermode=atomic -coverprofile=coverage.out ./... | ||
|
|
||
| - name: go mod |
There was a problem hiding this comment.
nit: maybe a different name for this test step, like "check vendoring"
aarongable
approved these changes
Jan 21, 2022
|
lol oops sorry that's what I get for getting distracted in the middle of a review |
|
https://go.dev/ref/mod#go-mod-verify Might want to look into this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11