Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Add a proper INFO style output unmarshaller#25

Merged
beautifulentropy merged 2 commits intomainfrom
replace-cluster-info-parser
Jan 28, 2022
Merged

Add a proper INFO style output unmarshaller#25
beautifulentropy merged 2 commits intomainfrom
replace-cluster-info-parser

Conversation

@beautifulentropy
Copy link
Copy Markdown
Member

@beautifulentropy beautifulentropy commented Jan 25, 2022

  • Replace yaml.Unmarshal() in the redis/client package with unmarshalClusterInfo()
  • Fix bad mock of the 'cluster info' output in redis/client package tests

Fixes #4

@beautifulentropy beautifulentropy force-pushed the replace-cluster-info-parser branch from ce6ac9e to c463d17 Compare January 25, 2022 23:26
@beautifulentropy beautifulentropy marked this pull request as ready for review January 25, 2022 23:28
jsha
jsha previously requested changes Jan 25, 2022
Copy link
Copy Markdown

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread src/redis/client/client.go Outdated
Comment thread src/redis/client/client.go Outdated
@beautifulentropy beautifulentropy requested a review from jsha January 26, 2022 00:46
@beautifulentropy beautifulentropy dismissed jsha’s stale review January 28, 2022 04:06

All comments addressed and jsha is OOO

@beautifulentropy beautifulentropy merged commit b2bb0e3 into main Jan 28, 2022
@beautifulentropy beautifulentropy deleted the replace-cluster-info-parser branch January 28, 2022 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a nodes info output parser that doesn't rely on treating it like YAML

3 participants