You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So a scenario verifying that the folder and file are actually created?...And a spec showing that the method calls frankly_screenshot. I thought maybe furter.rb was above testing since I don't think I saw anything in there for it yet... :)
There is some other logic in there that could be covered by specs as well.
I'm actually surprised that coveralls didn't pick it up.
On May 29, 2013 7:28 AM, "Jeremy Stewart" notifications@github.com wrote:
So a scenario verifying that the folder and file are actually
created?...And a spec showing that the method calls frankly_screenshot. I
thought maybe furter.rb was above testing since I don't think I saw
anything in there for it yet... :)
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-18610144
.
Coverage remained the same when pulling a26692c on jlstewart379:screenshot into c90d837 on leviwilson:master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking a screenshot with furter.