Security: Raw exception details returned to caller in DTMF tool#5308
Open
tuanaiseo wants to merge 1 commit intolivekit:mainfrom
Open
Conversation
`send_dtmf_events` catches broad exceptions and returns `str(e)` directly to the tool caller. Provider/SDK exceptions can include internal endpoint details, request metadata, or other sensitive context that should not be exposed to end users. Affected files: send_dtmf.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
send_dtmf_eventscatches broad exceptions and returnsstr(e)directly to the tool caller. Provider/SDK exceptions can include internal endpoint details, request metadata, or other sensitive context that should not be exposed to end users.Severity:
mediumFile:
livekit-agents/livekit/agents/beta/tools/send_dtmf.pySolution
Catch expected exception types and return sanitized user-safe errors. Log full exception details server-side with redaction controls instead of returning raw exception text.
Changes
livekit-agents/livekit/agents/beta/tools/send_dtmf.py(modified)Testing