fix(pipeline): surface validation error details in tool execution#5329
Draft
nickderobertis wants to merge 1 commit intolivekit:mainfrom
Draft
Conversation
…tion Wrap ValidationError/ValueError in ToolError in voice/generation.py's _execute_tools_task, matching the pattern from PR livekit#5193 for the realtime path. Without this, the LLM only sees "An internal error occurred" instead of the actual validation error details. Resolves ENG-2596 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
nickderobertis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidationError/ValueErrorinToolErrorinvoice/generation.py's_execute_tools_task, matching the pattern established by fix(llm): surface validation error details to LLM on function call argument failures #5193 for the realtime pathlogger.exceptiontologger.warningto match the realtime path convention"An internal error occurred"instead of the actual validation error details when tool argument parsing fails in the voice pathContext
#5193 fixed this for the realtime path (
llm/utils.py), but the equivalent pipeline code invoice/generation.pywas not updated.Fixes #5164 (voice path)
Test plan
ToolErrorsurfaces message inmake_tool_outputwhile rawValueErrorproduces generic messageTestExecuteFunctionCallValidationErrorstests still passmake checkpasses (format, lint, type-check)🤖 Generated with Claude Code