Remove RTC config options#257
Draft
MaxHeimbrock wants to merge 2 commits intomainfrom
Draft
Conversation
…ToProto Both ToProto methods crashed on default-constructed instances because their array fields (RTCConfiguration.IceServers, IceServer.Urls) have no initializer and the proto serialization path iterated them without a null guard. Adds null guards before the foreach/AddRange, and regression tests covering both cases plus a happy-path round-trip. EditModeTests.asmdef now references Google.Protobuf.dll so the happy-path test can assert on the serialized RepeatedField contents. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is very low level WebRTC stuff we don't really expect anyone to work with. Also it was not fully functional to be set by users.
Changes