fix: close stream controllers on room disconnect#633
Open
LautaroPetaccio wants to merge 5 commits intolivekit:mainfrom
Open
fix: close stream controllers on room disconnect#633LautaroPetaccio wants to merge 5 commits intolivekit:mainfrom
LautaroPetaccio wants to merge 5 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: cb2daa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Room.disconnect()removed event listeners and calledremoveAllListeners(), but never closed theReadableStreamDefaultControllerinstances stored inbyteStreamControllersandtextStreamControllers. If a sender disconnects mid-transfer (so no trailer is ever received), the receiving side's stream stays open forever. Each open stream holds a controller reference and any buffered chunks, preventing GC.How
After the FFI disconnect callback completes but before removing listeners, iterate both
byteStreamControllersandtextStreamControllers, callcontroller.close()on each (wrapped in try/catch since a controller may already be closed), and clear the maps. This ensures streams that never received a trailer are properly terminated.Test coverage
New E2E test
cleans up stream controllers when disconnecting during an active stream— opens a text stream, deliberately does not consume it, disconnects the receiver, and verifies no hang or throw from the abandoned controller.