Skip to content

Update dependency vite to v8 #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+377 −288
Open

Update dependency vite to v8 #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion livekit-rtc/jupyter-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"globals": "^17.0.0",
"typescript": "~5.7.3",
"typescript-eslint": "^8.56.1",
"vite": "^6.4.1",
"vite": "^8.0.0",
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 vite-plugin-singlefile@2.3.0 does not support Vite 8 in its peer dependencies

The vite-plugin-singlefile is locked to version 2.3.0 in the lockfile, which declares peer dependency vite: ^5.4.11 || ^6.0.0 || ^7.0.0 — Vite 8 is not included. This is confirmed by the lockfile (pnpm-lock.yaml) which shows vite-plugin-singlefile@2.3.0 resolved against vite@8.0.10 despite the incompatible peer constraint. The fix is straightforward: vite-plugin-singlefile@2.3.3 (within the ^2.3.0 specifier range) adds ^8.0.0 to its vite peer dependency. Regenerating the lockfile (or bumping the specifier) would resolve to 2.3.3 and fix the mismatch.

Prompt for agents 
The vite version was bumped to ^8.0.0 but the lockfile still pins vite-plugin-singlefile at 2.3.0, which only declares peer support for vite 5/6/7. Version 2.3.3 of vite-plugin-singlefile adds vite 8 support and is within the ^2.3.0 semver range. Regenerate the lockfile (e.g. pnpm install) so that vite-plugin-singlefile resolves to at least 2.3.3, eliminating the peer dependency mismatch.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 @vitejs/plugin-react@4.7.0 peer dependency does not include Vite 8

@vitejs/plugin-react@4.7.0 declares its peer dependency as vite: ^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 (pnpm-lock.yaml:613), which does not include Vite 8. Bumping vite to ^8.0.0 violates this constraint and could cause build failures or runtime errors due to breaking API changes between Vite major versions. The plugin version needs to be updated to one that supports Vite 8.

Prompt for agents 
The vite dependency was bumped from ^6.4.1 to ^8.0.0, but @vitejs/plugin-react@4.7.0 (line 23 of package.json) only supports vite ^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 (verified in pnpm-lock.yaml:613). You need to also bump @vitejs/plugin-react to a version that supports Vite 8 (likely a new major version of the plugin). Check the @vitejs/plugin-react changelog/releases for a version with vite ^8.0.0 in its peerDependencies.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"vite-plugin-singlefile": "^2.3.0"
}
}
Loading
Loading