Fix undefined issue while logging from node-loggly-bulk library #11
Merged
mchaudhary merged 3 commits intologgly:masterfrom Jun 6, 2017
Merged
Fix undefined issue while logging from node-loggly-bulk library #11mchaudhary merged 3 commits intologgly:masterfrom
mchaudhary merged 3 commits intologgly:masterfrom
Conversation
added 2 commits
May 26, 2017 13:25
Author
|
I have tested below scenarios with both node-loggly-bulk and winston-loggly-bulk libraries.
|
|
When you test sending JSON, does Loggly parse the JSON automatically? |
Author
|
@mostlyjason Yes, Loggly parsed the JSON with both node-loggly-bulk and winston-loggly-bulk libraries. See the below examples with parsed JSON screenshots. winston-loggly-bulk library: I am sending JSON data: JSON parsed result on Loggly: node-loggly-bulk library: I am sending JSON data: JSON parsed result on Loggly: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I debugged code with
node-loggly-bulklibrary and found that type ofmsgis a string which should be an object(winston-loggly-bulklibrary is sending log data tonode-loggly-bulkin object form). That's why the value ofmsg.messageobject wasundefined.From node version 7.0.0, node will throw an error when we will pass invalid input to Buffer.byteLength.
Ref: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V7.md#7.0.0
Merged PR: nodejs/node#8946
In this PR I have put a condition to check if the
msgis a string (If we are logging usingnode-loggly-bulk) and then converting to an object. So both library will work correctly.It will fix the issue #10.