Add configurable CGM sensor lifetime for sensor change alarm#579
Merged
marionbarker merged 3 commits intodevfrom Apr 10, 2026
Merged
Add configurable CGM sensor lifetime for sensor change alarm#579marionbarker merged 3 commits intodevfrom
marionbarker merged 3 commits intodevfrom
Conversation
The sensor change alarm was hardcoded to a 10-day lifetime, causing false alerts for users with 15-day G7 sensors. Add a per-alarm sensorLifetimeDays setting (7-15 days, default 10) so users can match their actual sensor duration. Also fix a bug where the sensor and pump change alarms would fire when no insert time was available (defaulting to epoch 0).
Collaborator
|
LGTM (Except the conflicts) |
# Conflicts: # Tests/AlarmConditions/Helpers.swift
Contributor
Author
|
Merge conflicts with |
marionbarker
reviewed
Apr 9, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
I had a few questions.
marionbarker
approved these changes
Apr 10, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approved with updated comments and repeated test.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary