Skip to content

Update depthai-api (python3_exact_version)#121

Merged
alex-luxonis merged 2 commits intomasterfrom
python3_exact_version
Jul 28, 2020
Merged

Update depthai-api (python3_exact_version)#121
alex-luxonis merged 2 commits intomasterfrom
python3_exact_version

Conversation

@alex-luxonis
Copy link
Copy Markdown
Collaborator

See PR luxonis/depthai-python#28

With multiple python3 versions installed (side by side, or within Conda environments),
CMake's find_package always returned the latest (e.g. even if we specify 3.6, if 3.7 is found, it is used instead).
With an older python3 interpreter enabled as default, this was causing a wrong lib to be built, not the one expected by the selected python3 interpreter.

However, find_package has an option EXACT that would solve the above issue, but we don't want to hardcode a specific version.
We query the version from the python3 interpreter and pass it to find_package.

@Luxonis-Brandon
Copy link
Copy Markdown

Tested on Mac and works fine. I'd say this is good to go.

@SzabolcsGergely
Copy link
Copy Markdown

lgtm

@alex-luxonis alex-luxonis merged commit b95fd30 into master Jul 28, 2020
@alex-luxonis alex-luxonis deleted the python3_exact_version branch July 28, 2020 18:41
SzabolcsGergely pushed a commit that referenced this pull request Oct 30, 2020
Update depthai-api (python3_exact_version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants