Conversation
korshaknn
force-pushed
the
knn_return_back_waypoints_per_route
branch
from
582f204 to
509fbc0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1509 +/- ##
============================================
+ Coverage 76.89% 76.90% +0.01%
Complexity 937 937
============================================
Files 129 129
Lines 4016 4019 +3
Branches 582 582
============================================
+ Hits 3088 3091 +3
Misses 678 678
Partials 250 250
|
korshaknn
force-pushed
the
knn_return_back_waypoints_per_route
branch
from
509fbc0 to
7a09011
Compare
|
@LukasPaczos ptal |
| * List of {@link DirectionsWaypoint} objects. Each {@code waypoint} is an input coordinate | ||
| * snapped to the road and path network. The {@code waypoint} appear in the list in the order of | ||
| * the input coordinates. | ||
| * @deprecated the waypoints are returned in the root of the response only if |
There was a problem hiding this comment.
Why did you remove @Deprecated? It's deprecated on backend.
There was a problem hiding this comment.
Nav API team mentioned earlier today that these changes are not yet available. Unless the situation is different @dzinad?
There was a problem hiding this comment.
When did they mention that?
It's working for me. See
https://api.mapbox.com/directions/v5/mapbox/driving-traffic/138.4282743,34.9665031;138.42594,34.9665461?access_token=<TOKEN>&geometries=polyline6&overview=full&steps=true&compute_toll_cost=true
vs
https://api.mapbox.com/directions/v5/mapbox/driving-traffic/138.4282743,34.9665031;138.42594,34.9665461?access_token=<TOKEN>&geometries=polyline6&overview=full&steps=true&compute_toll_cost=true&waypoints_per_route=true.
Or do you mean EV waypoints? Then probably yes, it's still in development but this parameter is not about EV. Anyways, I'm not against not deprecating it at all.
There was a problem hiding this comment.
Ah, it was about EV waypoints indeed, I missed that! In any case we might give it a little bit more time to mature before we deprecate.
3 participants
return back #1503